-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't leak the viewport subscription when the viewport data is read #4420
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it's working properly in the docs snapshots
This is on hold to address a few other leaks as well. |
7119486
to
1acbafa
Compare
1acbafa
to
c858777
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this close #4410?
Tested w/ docs snapshot tool by undoing the mitigations I had put in.
Confirmed w/ latest docker image the number of listeners grows unbounded by creating my own class extending ws
which increments/decrements on newListener
and removeListener
.
With this change, number of listeners was not growing and stayed at a consistent overhead of 12 even after closing/re-opening the connection.
Fixed the linked issue, thanks. |
Fixes #4410