Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update R client to some macro renaming in C++ client. #4439

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Update R client to some macro renaming in C++ client. #4439

merged 2 commits into from
Sep 5, 2023

Conversation

jcferretti
Copy link
Member

No description provided.

@jcferretti jcferretti added this to the August 2023 milestone Sep 4, 2023
@jcferretti jcferretti self-assigned this Sep 4, 2023
alexpeters1208
alexpeters1208 approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@alexpeters1208 alexpeters1208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devinrsmith devinrsmith added the release blocker A bug/behavior that puts is below the "good enough" threshold to release. label Sep 5, 2023
@jcferretti jcferretti merged commit d3b2147 into deephaven:main Sep 5, 2023
11 checks passed
@jcferretti jcferretti deleted the cfs-r-cpp-location-macro-rename branch September 5, 2023 15:35
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexpeters1208 alexpeters1208 alexpeters1208 approved these changes

@chipkent chipkent Awaiting requested review from chipkent chipkent is a code owner

@rcaudy rcaudy Awaiting requested review from rcaudy rcaudy is a code owner

Assignees

@jcferretti jcferretti

Labels
NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. release blocker A bug/behavior that puts is below the "good enough" threshold to release.
Projects
None yet
Milestone
August 2023
Development

Successfully merging this pull request may close these issues.
3 participants
@jcferretti @alexpeters1208 @devinrsmith