Setup ExecutionContext in Barrage Client Examples #4461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbauernfeind
added
bug
devinrsmith
reviewed
Sep 8, 2023
Util/src/main/java/io/deephaven/util/thread/ThreadInitializationFactory.java
Show resolved
Hide resolved
devinrsmith
reviewed
Sep 8, 2023
| @@ -23,10 +24,20 @@ public interface ThreadInitializationFactory { | |||
| return clazz.getDeclaredConstructor().newInstance(); | |||
| } catch (ClassNotFoundException | NoSuchMethodException | InvocationTargetException | |||
| | InstantiationException | IllegalAccessException e) { | |||
|
|
|||
| // TODO (https://github.com/deephaven/deephaven-core/issues/4040): | |||
There was a problem hiding this comment.
I believe so; I acquired it from Colin. It is the ticket related to python debug initialization. This snippet can be reverted once Colin takes an alternative approach.
There was a problem hiding this comment.
Yes, this is the ticket (in several parts...) that will address this.
devinrsmith
approved these changes
Sep 8, 2023
niloc132
approved these changes
Sep 8, 2023
|
Labels indicate documentation is required. Issues for documentation have been opened: How-to: https://github.com/deephaven/deephaven.io/issues/3162 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was recently discovered that the barrage client examples were no longer working. This was a side effect of adding multiple update graph support to the engine.
Additionally, there is server-side configuration that is accessible to the client that requires a class that is only in the server package. This server-side configuration is likely to be reworked in the near future and even possibly the need for this server-side class that can't be loaded. For now, I've modified the thread factory initialization to ignore class not found exceptions within the server-side package.
To work around this while still using a previous release one either needs to provide their own
dh-defaults.propfile or add the following jvm flag-Dthread.initialization=to remove the reference to the server-side class.From a documentation perspective, we should add setup instructions for the ticking java-client use case (as otherwise demonstrated by the example).