Fix for inconsistent tests #4483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbasralian
added
NoDocumentationNeeded
NoReleaseNotesNeeded
rbasralian
requested review from
chipkent,
jmao-denver and
rcaudy
as code owners
jmao-denver
reviewed
Sep 14, 2023
Comment on lines
+52
to
+56
| print("Adding row at time: " + str(datetime.now())) | ||
| append_only_input_table.add(new_table([string_col(name='MyStr', data=['test string'])])) | ||
| print("add() returned at time: " + str(datetime.now())) | ||
| self.wait_ticking_table_update(result_table, row_count=1, timeout=30) | ||
| self.assertEqual(result_table.size, 1) | ||
| print("result_table has 1 row at time: " + str(datetime.now())) |
There was a problem hiding this comment.
So the row somehow vanished. Is the table a blink table?
There was a problem hiding this comment.
nah — it's an input table, which is backed by an AppendOnlyArrayBackedMutableTable
rcaudy
reviewed
Sep 14, 2023
rcaudy
reviewed
Sep 14, 2023
…`. Include `function_generated_table` in `__all__`.
chipkent
previously approved these changes
Sep 15, 2023
rcaudy
approved these changes
Sep 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements to the intermittently-failing tests in
test_function_genreated_table.py(#4476)(2/3 fixed —
test_generated_table_1triggerstill a mystery)