Modify layout of grouping files #4525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malhotrashivam
added
bug
malhotrashivam
changed the title
malhotrashivam
changed the title
malhotrashivam
changed the title
malhotrashivam
force-pushed
the
sm-grouping-dir
branch
from
3e67090
to
401114a
Compare
malhotrashivam
force-pushed
the
sm-grouping-dir
branch
from
fda131e
to
9535401
Compare
malhotrashivam
force-pushed
the
sm-grouping-dir
branch
from
9535401
to
3ce0a5b
Compare
malhotrashivam
changed the title
lbooker42
reviewed
Oct 18, 2023
extensions/parquet/table/src/main/java/io/deephaven/parquet/table/ParquetTools.java
Outdated
Show resolved
Hide resolved
extensions/parquet/table/src/main/java/io/deephaven/parquet/table/ParquetTools.java
Outdated
Show resolved
Hide resolved
extensions/parquet/table/src/main/java/io/deephaven/parquet/table/ParquetTools.java
Outdated
Show resolved
Hide resolved
...nsions/parquet/table/src/test/java/io/deephaven/parquet/table/ParquetTableReadWriteTest.java
Outdated
Show resolved
Hide resolved
extensions/parquet/table/src/main/java/io/deephaven/parquet/table/layout/ParquetFileHelper.java
Outdated
Show resolved
Hide resolved
...nsions/parquet/table/src/test/java/io/deephaven/parquet/table/ParquetTableReadWriteTest.java
Outdated
Show resolved
Hide resolved
malhotrashivam
force-pushed
the
sm-grouping-dir
branch
from
75aa4b8
to
66717a8
Compare
rcaudy
reviewed
Oct 26, 2023
extensions/parquet/table/src/main/java/io/deephaven/parquet/table/layout/ParquetFileHelper.java
Outdated
Show resolved
Hide resolved
| final String prefix = minusParquetSuffix(path); | ||
| return columnName -> prefix + "_" + columnName + "_grouping.parquet"; | ||
| /** | ||
| * Generates a grouping file path relative to the table destination file path. |
There was a problem hiding this comment.
I thought we were re-branding "grouping" to "indexing" in this PR for new/changed code, to avoid creating a subsequent task?
There was a problem hiding this comment.
@lbooker42 mentioned that he will be doing renaming in his changes, so I didn't do it here.
There was a problem hiding this comment.
My complaint was more that we're adding more work with some of the new code, and creating a "moving target" for him.
extensions/parquet/table/src/main/java/io/deephaven/parquet/table/ParquetTools.java
Outdated
Show resolved
Hide resolved
extensions/parquet/table/src/main/java/io/deephaven/parquet/table/ParquetTools.java
Show resolved
Hide resolved
...nsions/parquet/table/src/test/java/io/deephaven/parquet/table/ParquetTableReadWriteTest.java
Show resolved
Hide resolved
...s/parquet/table/src/main/java/io/deephaven/parquet/table/location/ParquetColumnLocation.java
Outdated
Show resolved
Hide resolved
rcaudy
reviewed
Oct 27, 2023
...s/parquet/table/src/main/java/io/deephaven/parquet/table/location/ParquetColumnLocation.java
Outdated
Show resolved
Hide resolved
extensions/parquet/table/src/main/java/io/deephaven/parquet/table/ParquetTools.java
Show resolved
Hide resolved
malhotrashivam
force-pushed
the
sm-grouping-dir
branch
from
2582672
to
91502ab
Compare
lbooker42
reviewed
Oct 30, 2023
rcaudy
reviewed
Oct 31, 2023
extensions/parquet/table/src/main/java/io/deephaven/parquet/table/ParquetTools.java
Show resolved
Hide resolved
malhotrashivam
force-pushed
the
sm-grouping-dir
branch
3 times, most recently
from
e50c4b4
to
ec762d3
Compare
malhotrashivam
force-pushed
the
sm-grouping-dir
branch
from
ec762d3
to
bbeef06
Compare
rcaudy
approved these changes
Oct 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4283
Proposal document for new layout.