Support ZonedDateTime columns in plots #4528
Conversation
There was a problem hiding this comment.
Tested with the snippet in the ticket:
from deephaven import empty_table
from deephaven.plot import Figure
t = empty_table(1).update_view(formulas=['t=(ZonedDateTime)null', 'y=(long)null'])
plot = Figure().plot_xy(t=t, x="t", y="y", series_name="sample").show()
| public double getDouble(int i) { | ||
| final Instant value = DateTimeUtils.toInstant((ZonedDateTime) getDataColumn().get(i)); | ||
| return value == null ? Double.NaN : DateTimeUtils.epochNanos(value); | ||
| } |
There was a problem hiding this comment.
Does this even get used? I have the impression that web is snapshotting data directly rather than via any Plot code. Which is good, because this is a pretty sub-optimal way to fetch bulk data.
There was a problem hiding this comment.
Here is some test code I have been using.
from deephaven import time_table
from deephaven.time import to_j_time_zone
from deephaven.plot.figure import Figure
tz = to_j_time_zone("ET")
t = time_table("PT00:00:01").update(["X=toZonedDateTime(Timestamp,tz)","Y=i"])
m = t.meta_table
p = Figure().plot_xy(series_name="Test", t=t, x="X", y="Y").show()In the 0.28.1 demo, this fails with:
java.lang.UnsupportedOperationException: Unsupported numeric data type: columnName=X type=class java.time.ZonedDateTime
The equivalent Groovy is passing in my branch code.
tz = timeZone("ET")
t = timeTable("PT00:00:01").update("X=toZonedDateTime(Timestamp,tz)","Y=i")
m = t.meta()
p = figure().plot("Test", t, "X", "Y").show()I will disable and test the code again.
There was a problem hiding this comment.
Confirmed that commenting out the new code results in an exception: java.lang.UnsupportedOperationException: Unsupported numeric data type: columnName=X type=class java.time.ZonedDateTime
There was a problem hiding this comment.
A deep dive indicates that some, but not all of this code is called. The methods to get type are called, but the getDouble methods are not called. Removal of those functions should be part of a more comprehensive refactor and not this PR.
|
Labels indicate documentation is required. Issues for documentation have been opened: How-to: https://github.com/deephaven/deephaven.io/issues/3229 |
Support ZonedDateTime columns in plots.
Resolves #4466