-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename and update docs for ObjectService ServerData and ClientData #4535
Rename and update docs for ObjectService ServerData and ClientData #4535
Conversation
As discussed in #4490 (comment) |
I don't think the python client tests are sufficient to ensure this update is valid - it doesn't exercise the messageStream with references for testing. The proposed Echo plugin in #4490 would be a good candidate for the python client to test against. |
Don't forget to regenerate the gwt bindings - the JS code for the protos will be generated, so methods will be missing. Smoke testing is possible for the python server and js client with any of the existing plotly/matplotlib stuff, and for the python client with the existing runfunc plugins. |
I forget how to do the JS code updates... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
33d5bbd
Tested against https://github.com/deephaven/deephaven.io/pull/3175 |
Tested against https://github.com/deephaven/deephaven.io/pull/3087 |
No description provided.