Add kwargs to function generated tables #4542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexpeters1208
added
NoDocumentationNeeded
python-server-side
NoReleaseNotesNeeded
alexpeters1208
changed the title
alexpeters1208
requested review from
chipkent,
jmao-denver and
rcaudy
as code owners
jmao-denver
reviewed
Sep 25, 2023
jmao-denver
reviewed
Sep 25, 2023
jmao-denver
reviewed
Sep 25, 2023
jmao-denver
reviewed
Sep 25, 2023
chipkent
reviewed
Sep 25, 2023
…hange types to tuple and dict
Co-authored-by: Jianfeng Mao <4297243+jmao-denver@users.noreply.github.com>
chipkent
reviewed
Sep 26, 2023
chipkent
approved these changes
Sep 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In working on the function-generated tables blog, I wanted to be able to use arguments in the table-generating function. This PR adds that functionality.