Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing AuthContext on New Partition #4550

Merged
merged 4 commits into from
Sep 25, 2023

Conversation

nbauernfeind
Copy link
Member

Fixes #4543 by improving the time of error when auth context is not provided and by installing an auth context when processing changes to a union source manager (which might create new listeners).

@nbauernfeind nbauernfeind added bug Something isn't working core Core development tasks NoDocumentationNeeded partitioned_tables ReleaseNotesNeeded Release notes are needed labels Sep 25, 2023
@nbauernfeind nbauernfeind added this to the September 2023 milestone Sep 25, 2023
@nbauernfeind nbauernfeind self-assigned this Sep 25, 2023
Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this version, and keep the issue open while we think about more safety checks.

@nbauernfeind nbauernfeind merged commit ae625af into deephaven:main Sep 25, 2023
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working core Core development tasks NoDocumentationNeeded partitioned_tables ReleaseNotesNeeded Release notes are needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address missing Authorization Context safety
2 participants