Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++ Client: remove the "Fluent API" from code and docs. Also, fix docs. #4629

Merged
merged 3 commits into from
Oct 17, 2023
Merged

C++ Client: remove the "Fluent API" from code and docs. Also, fix docs. #4629

merged 3 commits into from
Oct 17, 2023

Conversation

kosak
Copy link
Contributor

@kosak kosak commented Oct 12, 2023

No description provided.

@kosak kosak added NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. labels Oct 12, 2023
@jcferretti jcferretti added this to the October 2023 milestone Oct 12, 2023
jcferretti
jcferretti previously approved these changes Oct 12, 2023
View reviewed changes
alexpeters1208
alexpeters1208 approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@alexpeters1208 alexpeters1208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only looked at the files directly relevant to the R client, and specifcally at SortPairs gettting moved around. LGTM

@kosak kosak merged commit ec6d013 into deephaven:main Oct 17, 2023
10 checks passed
@kosak kosak deleted the kosak_remove-fluent branch October 17, 2023 15:17
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jcferretti jcferretti jcferretti approved these changes

@alexpeters1208 alexpeters1208 alexpeters1208 approved these changes

@chipkent chipkent Awaiting requested review from chipkent chipkent is a code owner

@rcaudy rcaudy Awaiting requested review from rcaudy rcaudy is a code owner

Assignees

@jcferretti jcferretti

Labels
NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed.
Projects
None yet
Milestone
October 2023
Development

Successfully merging this pull request may close these issues.
3 participants
@kosak @jcferretti @alexpeters1208