BarrageSubscriptionImpl: fix race conditions in subscription logic #4630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbauernfeind
added
bug
rcaudy
reviewed
Oct 12, 2023
| @@ -17,7 +17,7 @@ public class GrpcUtil { | |||
| private static final Logger log = LoggerFactory.getLogger(GrpcUtil.class); | |||
|
|
|||
| public static StatusRuntimeException securelyWrapError(final Logger log, final Throwable err) { | |||
| return securelyWrapError(log, err, Code.INVALID_ARGUMENT); | |||
| return securelyWrapError(log, err, Code.ABORTED); | |||
There was a problem hiding this comment.
My reading of the documentation for ABORTED suggests that this is not the best change to make. It also seems like a deviation from our norms. Maybe @niloc132 can weigh in.
There was a problem hiding this comment.
Cristian, Colin, and I dug in a bit and agree that ABORTED is an acceptable alternative. Per our discussion, Ryan, it would be better to change this in isolation swapping the status type for other similar cases.
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java
Show resolved
Hide resolved
| * | ||
| * @return number of rows received by the subscription handler | ||
| */ | ||
| long getRowsReceived(); |
There was a problem hiding this comment.
Check if Devin, Andy, or Charles are using this. I expect not.
java-client/barrage/src/main/java/io/deephaven/client/impl/BarrageSubscriptionImpl.java
Outdated
Show resolved
Hide resolved
java-client/barrage/src/main/java/io/deephaven/client/impl/BarrageSubscriptionImpl.java
Outdated
Show resolved
Hide resolved
java-client/barrage/src/main/java/io/deephaven/client/impl/BarrageSubscriptionImpl.java
Outdated
Show resolved
Hide resolved
java-client/barrage/src/main/java/io/deephaven/client/impl/BarrageSubscriptionImpl.java
Outdated
Show resolved
Hide resolved
extensions/barrage/src/main/java/io/deephaven/extensions/barrage/table/BarrageTable.java
Outdated
Show resolved
Hide resolved
extensions/barrage/src/main/java/io/deephaven/extensions/barrage/table/BarrageTable.java
Show resolved
Hide resolved
…eProducer.java Co-authored-by: Ryan Caudy <rcaudy@gmail.com>
…rageSubscriptionImpl.java Co-authored-by: Ryan Caudy <rcaudy@gmail.com>
…rageSubscriptionImpl.java Co-authored-by: Ryan Caudy <rcaudy@gmail.com>
nbauernfeind
force-pushed
the
gh_4594
branch
6 times, most recently
from
b7e0dd4
to
72d05b3
Compare
rcaudy
reviewed
Oct 16, 2023
extensions/barrage/src/main/java/io/deephaven/extensions/barrage/table/BarrageTable.java
Outdated
Show resolved
Hide resolved
extensions/barrage/src/main/java/io/deephaven/extensions/barrage/table/BarrageTable.java
Outdated
Show resolved
Hide resolved
extensions/barrage/src/main/java/io/deephaven/extensions/barrage/table/BarrageTable.java
Outdated
Show resolved
Hide resolved
extensions/barrage/src/main/java/io/deephaven/extensions/barrage/table/BarrageTable.java
Show resolved
Hide resolved
extensions/barrage/src/main/java/io/deephaven/extensions/barrage/table/BarrageTable.java
Outdated
Show resolved
Hide resolved
java-client/barrage/src/main/java/io/deephaven/client/impl/BarrageSubscriptionImpl.java
Outdated
Show resolved
Hide resolved
java-client/barrage/src/main/java/io/deephaven/client/impl/BarrageSubscriptionImpl.java
Outdated
Show resolved
Hide resolved
java-client/barrage/src/main/java/io/deephaven/client/impl/BarrageSubscriptionImpl.java
Outdated
Show resolved
Hide resolved
java-client/barrage/src/main/java/io/deephaven/client/impl/BarrageSubscriptionImpl.java
Outdated
Show resolved
Hide resolved
java-client/barrage/src/main/java/io/deephaven/client/impl/BarrageSubscriptionImpl.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Ryan Caudy <rcaudy@gmail.com>
rcaudy
reviewed
Oct 17, 2023
extensions/barrage/src/main/java/io/deephaven/extensions/barrage/table/BarrageTable.java
Outdated
Show resolved
Hide resolved
java-client/barrage/src/main/java/io/deephaven/client/impl/BarrageSnapshot.java
Outdated
Show resolved
Hide resolved
java-client/barrage/src/main/java/io/deephaven/client/impl/BarrageSnapshot.java
Outdated
Show resolved
Hide resolved
java-client/barrage/src/main/java/io/deephaven/client/impl/BarrageSnapshotImpl.java
Outdated
Show resolved
Hide resolved
java-client/barrage/src/main/java/io/deephaven/client/impl/BarrageSnapshotImpl.java
Outdated
Show resolved
Hide resolved
java-client/barrage/src/main/java/io/deephaven/client/impl/BarrageSnapshotImpl.java
Outdated
Show resolved
Hide resolved
rcaudy
reviewed
Oct 17, 2023
extensions/barrage/src/main/java/io/deephaven/extensions/barrage/table/BarrageTable.java
Show resolved
Hide resolved
Co-authored-by: Ryan Caudy <rcaudy@gmail.com>
rcaudy
approved these changes
Oct 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #803
Fixes #3300
Fixes #4594
The rnd4 (1:56pm MT) nightlies: https://github.com/nbauernfeind/deephaven-core/actions/runs/6552157706