A few cleanups and bug fixes #4636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation.testViewIncrementalRandomizedPerformanceTest
…n initializing UpdatePerformanceTracker.InternalState. Don't install an unncessary one during flush.
…to debug flag, by making RefCountedCow's debug flag independent. Introduce private debug flag for SingleRange, rather than sharing RspArray's.
rcaudy
added
bug
nbauernfeind
previously approved these changes
Oct 13, 2023
engine/table/src/main/java/io/deephaven/engine/table/impl/select/SelectColumn.java
Outdated
Show resolved
Hide resolved
cpwright
previously approved these changes
Oct 13, 2023
engine/rowset/src/main/java/io/deephaven/engine/rowset/impl/singlerange/SingleRange.java
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/select/SelectColumn.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/partitioned/LongConstantColumn.java
Show resolved
Hide resolved
cpwright
approved these changes
Oct 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestFormulaArrayEvaluation.testViewIncrementalRandomizedPerformanceTestSelectColumnimplementationsUpdateGraphin theExecutionContextwhen initializingUpdatePerformanceTracker.InternalState. Don't install an unnecessary one during flush.RefCountedCow/RspArraystatic initialization deadlock due to debug flag, by makingRefCountedCow's debug flag independent. Introduce private debug flag forSingleRange, rather than sharingRspArray's.Fixes #4383