Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up some legacy code and improve build #4674

Merged
merged 14 commits into from
Nov 30, 2023
Merged

Conversation

rcaudy
Copy link
Member

@rcaudy rcaudy commented Oct 19, 2023

  • Addresses a build issue on ARM macs by specifying the platform for the proto-backplane-grpc image in proto/raw-js-openapi/Dockerfile
  • Closes Clean up FishUtil #4460 by deleting, inlining, or moving FishUtil code and deleting the FishUtil module
  • Closes Eliminate :Net from Build #3962 by deleting usages of :Net code

@rcaudy rcaudy added feature request New feature or request build clean up core Core development tasks labels Oct 19, 2023
@rcaudy rcaudy added this to the October 2023 milestone Oct 19, 2023
@rcaudy rcaudy self-assigned this Oct 19, 2023
@rcaudy rcaudy force-pushed the rwc-stuff branch 3 times, most recently from 21e21c3 to 1d21a08 Compare October 31, 2023 00:35
@rcaudy rcaudy marked this pull request as ready for review November 29, 2023 18:27
Copy link
Member

@niloc132 niloc132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for changes to proto/raw-js-openapi/Dockerfile

@rcaudy rcaudy enabled auto-merge (squash) November 30, 2023 17:51
@rcaudy rcaudy merged commit e719136 into deephaven:main Nov 30, 2023
11 checks passed
@rcaudy rcaudy deleted the rwc-stuff branch November 30, 2023 18:00
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build clean up core Core development tasks feature request New feature or request NoDocumentationNeeded ReleaseNotesNeeded Release notes are needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up FishUtil Eliminate :Net from Build
3 participants