Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve plotting error messages when the input type is bad. #4698

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

chipkent
Copy link
Member

Improve plotting error messages when the input type is bad. Prior error messages were not understandable.

Resolves #4603

Copy link
Contributor

@alexpeters1208 alexpeters1208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cloned your branch and tested, LGTM

@chipkent chipkent merged commit 909eff2 into deephaven:main Oct 24, 2023
16 checks passed
@chipkent chipkent deleted the 4603_plotby branch October 24, 2023 15:18
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: plotByOHLC does not accept Instants as open/close time params
3 participants