Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExportObject: Add onSuccess Callback for use in TableService#batch #4772

Merged
merged 4 commits into from
Nov 6, 2023

Conversation

nbauernfeind
Copy link
Member

Fixes #4754.

@nbauernfeind nbauernfeind added bug Something isn't working NoDocumentationNeeded release blocker A bug/behavior that puts is below the "good enough" threshold to release. ReleaseNotesNeeded Release notes are needed labels Nov 4, 2023
@nbauernfeind nbauernfeind added this to the October 2023 milestone Nov 4, 2023
@nbauernfeind nbauernfeind self-assigned this Nov 4, 2023
Copy link
Member

@devinrsmith devinrsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed that this PR appears to fix the race that I've been able to reliably reproduce otherwise.

@nbauernfeind nbauernfeind merged commit 914825d into deephaven:main Nov 6, 2023
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working NoDocumentationNeeded release blocker A bug/behavior that puts is below the "good enough" threshold to release. ReleaseNotesNeeded Release notes are needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Batch ETCR and Release race
3 participants