Add key column and column properties to JsPartitionedTable #4789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niloc132
reviewed
Nov 7, 2023
web/client-api/src/main/java/io/deephaven/web/client/api/JsPartitionedTable.java
Outdated
Show resolved
Hide resolved
web/client-api/src/main/java/io/deephaven/web/client/api/JsPartitionedTable.java
Outdated
Show resolved
Hide resolved
web/client-api/src/main/java/io/deephaven/web/client/api/JsPartitionedTable.java
Show resolved
Hide resolved
web/client-api/src/main/java/io/deephaven/web/client/api/JsPartitionedTable.java
Outdated
Show resolved
Hide resolved
web/client-api/src/main/java/io/deephaven/web/client/api/JsPartitionedTable.java
Outdated
Show resolved
Hide resolved
niloc132
reviewed
Nov 20, 2023
| * @return Table | ||
| */ | ||
| @JsProperty | ||
| public JsTable getKeyTable() { |
There was a problem hiding this comment.
This is probably not safe to return - what are you trying to do with this as an api consumer?
There was a problem hiding this comment.
The new UI being implemented for Partitioned Tables (spec) need to be able to display the table containing all the possible keys.
georgecwan
force-pushed
the
4773-jspartitionedtable-columns
branch
from
7b5b2bd
to
cac3c63
Compare
georgecwan
force-pushed
the
4773-jspartitionedtable-columns
branch
from
cac3c63
to
7c16c10
Compare
niloc132
approved these changes
Nov 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
getKeyColumns,getColumns, andgetKeyTabletoJsPartitionedTable.Resolves #4773.