Properly pass along exceptional state in BatchHandler #4802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in support of deephaven#4798. While this _is_ a fix to BatchHandler logic, it isn't the underlying cause of 4798. Next time 4798 is triggered in CI though, we should have more details to go off of.
devinrsmith
added
bug
rcaudy
reviewed
Nov 9, 2023
java-client/session/src/main/java/io/deephaven/client/impl/ExportStates.java
Show resolved
Hide resolved
rcaudy
approved these changes
Nov 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in support of #4798. While this is a fix to BatchHandler logic, it isn't the underlying cause of 4798. Next time 4798 is triggered in CI though, we should have more details to go off of.