Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop requesting column statistics for preview columns #4828

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

niloc132
Copy link
Member

Will be reverted as part of #188

Fixes #4825

@niloc132 niloc132 added bug Something isn't working jsapi NoDocumentationNeeded ReleaseNotesNeeded Release notes are needed labels Nov 14, 2023
@niloc132 niloc132 added this to the November 2023 milestone Nov 14, 2023
@niloc132
Copy link
Member Author

Rejecting this promise results in an error message in the popup, which makes it clear to the user they shouldn't expect this to work, and no server-side stack traces:

screenshot866

nbauernfeind
nbauernfeind previously approved these changes Nov 14, 2023
@niloc132 niloc132 enabled auto-merge (squash) November 14, 2023 20:53
@niloc132 niloc132 merged commit af1443c into deephaven:main Nov 14, 2023
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working jsapi NoDocumentationNeeded ReleaseNotesNeeded Release notes are needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ColumnStatistics on Previewed Column May throw IllegalArgumentException
3 participants