QueryPerformanceRecorder: Changes for CorePlus Integration #4862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbauernfeind
added
core
rcaudy
previously approved these changes
Nov 20, 2023
rcaudy
previously approved these changes
Nov 20, 2023
|
The performance queries should reintroduce Durations and an IntervalDuration as derived columns. |
nbauernfeind
force-pushed
the
qpr_coreplus
branch
from
7606682
to
870f277
Compare
cpwright
approved these changes
Nov 21, 2023
nbauernfeind
changed the title
rcaudy
approved these changes
Nov 21, 2023
|
Just to close the loop on the discussion, in case we ever look at this PR again: We discussed offline that we're happy with duration being computed using wall-clock time given that usage nanos is the sum of [parallelized] System.nanoTime. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.