Python Client: add instructions that set DEEPHAVEN_VERSION #5006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosak
added
NoDocumentationNeeded
NoReleaseNotesNeeded
devinrsmith
reviewed
Jan 4, 2024
py/client-ticking/README.md
Outdated
| cd ${DHROOT}/py/client-ticking | ||
| ``` shell | ||
| cd ${DHROOT} | ||
| export DEEPHAVEN_VERSION=$(./gradlew printVersion -q) |
There was a problem hiding this comment.
This should work. I see you don't export CFLAGS and instead do it during the build_ext command. The same can be done w/ DEEPHAVEN_VERSION for build_ext and bdist_wheel if we prefer.
py/client/README.md
Outdated
| ``` shell | ||
| $ export DEEPHAVEN_VERSION=$(./gradlew printVersion -q) |
There was a problem hiding this comment.
This can also just be set during bdist_wheel if we prefer.
kosak
force-pushed
the
kosak_update-doc-for-deephaven-version
branch
2 times, most recently
from
d33fbfd
to
164d42e
Compare
kosak
force-pushed
the
kosak_update-doc-for-deephaven-version
branch
from
164d42e
to
ce19a91
Compare
jcferretti
approved these changes
Mar 19, 2024
devinrsmith
approved these changes
Mar 19, 2024
jmao-denver
approved these changes
Mar 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.