Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't memoize retrieval of tables from JsPartitionedTable#getTable #5009

Merged
merged 2 commits into from
Jan 12, 2024
Merged

fix: Don't memoize retrieval of tables from JsPartitionedTable#getTable #5009

merged 2 commits into from
Jan 12, 2024

Commits on Jan 4, 2024

  1. fix: Don't memoize retrieval of tables from JsPartitionedTable#getTable 

    - Memoizing it is inconsistent with other methods like `WorkerConnection.getTable`, which always returns a new table
- Was unclear who the "owner" of the returned table was
- Memoization can happen at the client level if they need it
    @mofojed
    mofojed committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    90805c6 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2024

  1. Assign values before executing lambda 

    - Ensures that the values have not mutated when executing the lambda
    @mofojed
    mofojed committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    5a0c4e5 View commit details
    Browse the repository at this point in the history