Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate Double Error Notifications in jsapi and Error Log #5048

Merged
merged 10 commits into from
Jan 19, 2024
Merged

Eliminate Double Error Notifications in jsapi and Error Log #5048

merged 10 commits into from
Jan 19, 2024

Conversation

nbauernfeind
Copy link
Member

@nbauernfeind nbauernfeind commented Jan 17, 2024 •
edited
Loading

Fixes #5015.

This fixes:

  1. the double error notification experience via the jsapi
  2. ExportedTableUpdateMessage's error message is now obfuscated
  3. de-dupes identical errors by reusing the first-known UUID associated with the exception or a cause

@nbauernfeind nbauernfeind added bug Something isn't working core Core development tasks NoDocumentationNeeded authorization ReleaseNotesNeeded Release notes are needed labels Jan 17, 2024
@nbauernfeind nbauernfeind self-assigned this Jan 17, 2024
@nbauernfeind nbauernfeind marked this pull request as draft January 17, 2024 17:47
@nbauernfeind nbauernfeind marked this pull request as ready for review January 17, 2024 19:02
@nbauernfeind nbauernfeind changed the title ETUM: Use SessionService.ErrorTransformer on Table Failure Eliminate Double Error Notifications in jsapi and Error Log Jan 17, 2024
rcaudy
rcaudy previously approved these changes Jan 19, 2024
View reviewed changes
@nbauernfeind nbauernfeind enabled auto-merge (squash) January 19, 2024 18:34
@nbauernfeind nbauernfeind merged commit 1593f91 into deephaven:main Jan 19, 2024
19 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@niloc132 niloc132 niloc132 left review comments

@rcaudy rcaudy rcaudy approved these changes

Assignees

@nbauernfeind nbauernfeind

Labels
authorization bug Something isn't working core Core development tasks NoDocumentationNeeded ReleaseNotesNeeded Release notes are needed
Projects
None yet
Milestone
1. January 2024 (end of month)
Development

Successfully merging this pull request may close these issues.

Double error notification
3 participants
@nbauernfeind @niloc132 @rcaudy