fix: Mark JsPartitionedTable.getTable as nullable #5050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mofojed
added
NoDocumentationNeeded
NoReleaseNotesNeeded
|
@niloc132 is there a recommended way of throwing a specific error/error type so that I can react to this type of exception? In this case the client can easily just select a different key and recover. |
- Returning a `null` instead of an actual table is weird. Throw to indicate the key could not be found.
This reverts commit 810bf26.
mofojed
force-pushed
the
partition-table-error
branch
from
f387412
to
18aaa32
Compare
mofojed
changed the title
JsPartitionedTable.getTable as nullable
mofojed
changed the title
JsPartitionedTable.getTable as nullable
niloc132
approved these changes
Mar 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nullif the key is not found, as the table may not exist yet.