Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old benchmark script #5187

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Remove old benchmark script #5187

merged 1 commit into from
Feb 23, 2024

Conversation

devinrsmith
Copy link
Member

No description provided.

@devinrsmith devinrsmith self-assigned this Feb 22, 2024
@devinrsmith devinrsmith enabled auto-merge (squash) February 22, 2024 21:02
stanbrub
stanbrub reviewed Feb 22, 2024
View reviewed changes
Copy link
Contributor

@stanbrub stanbrub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README.md indicates that this was part of a nightly workflow. Were references to this code already removed elsewhere?

@devinrsmith
Copy link
Member Author

Yep, looks like we probably should have deleted these files as part of #3981

@devinrsmith devinrsmith merged commit 1640f37 into deephaven:main Feb 23, 2024
23 checks passed
@devinrsmith devinrsmith deleted the remove-old-benchmark-scripts branch February 23, 2024 18:04
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stanbrub stanbrub stanbrub approved these changes

Assignees

@devinrsmith devinrsmith

Labels
NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed.
Projects
None yet
Milestone
2. February 2024 (end of month)
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@devinrsmith @stanbrub