Quiesce RetainedRefrenceTracker#ensureReferencesDroppedInternal by Disabling CLEANUP_LOG_ENABLED by Default
#5188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbauernfeind
added
core
nbauernfeind
changed the title
RetainedRefrenceTracker#ensureReferencesDroppedInternal by Disabling CLEANUP_LOG_ENABLED by Default
rcaudy
approved these changes
Feb 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1152.
Ryan and I discussed #4575 as a better solution to this problem. In the meantime, we can disable cleanup logging by default. The other piece of work is not high priority and is not a trivial change (in terms of files touched; it is otherwise straightforward).