Fix bugs in moveColumns and renameColumns #5193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbauernfeind
added
bug
nbauernfeind
force-pushed
the
move_columns_fix
branch
from
859086d
to
3b5f066
Compare
nbauernfeind
force-pushed
the
move_columns_fix
branch
from
3b5f066
to
c0ba6a1
Compare
jmao-denver
previously approved these changes
Feb 26, 2024
There was a problem hiding this comment.
I really like the new Javadoc and the new tests, helped me understand the code much better. I wonder if we can add similar move+rename examples in the official docs as well since I couldn't find such an example there.
Suggested a small correction in javadoc at one place. Would defer the discussion about semantics to the experts.
Co-authored-by: Shivam Malhotra <malhotraashivam@gmail.com>
nbauernfeind
dismissed stale reviews from chipkent and jmao-denver
via
d8e01d3
malhotrashivam
previously approved these changes
Feb 27, 2024
chipkent
reviewed
Feb 27, 2024
Co-authored-by: Chip Kent <5250374+chipkent@users.noreply.github.com>
rcaudy
reviewed
Feb 28, 2024
engine/table/src/main/java/io/deephaven/engine/table/impl/QueryTable.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/QueryTable.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/QueryTable.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/QueryTable.java
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/QueryTable.java
Outdated
Show resolved
Hide resolved
rcaudy
reviewed
Feb 28, 2024
engine/table/src/main/java/io/deephaven/engine/table/impl/BaseTable.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/QueryTable.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/QueryTable.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/QueryTable.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/QueryTable.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/QueryTable.java
Outdated
Show resolved
Hide resolved
nbauernfeind
force-pushed
the
move_columns_fix
branch
from
b192365
to
f57851b
Compare
rcaudy
approved these changes
Feb 28, 2024
|
Labels indicate documentation is required. Issues for documentation have been opened: Community: https://github.com/deephaven/deephaven.io/issues/3750 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4824.
There were a few odd behaviors of the existing replace columns implementation. This hopefully makes behavior well defined and consistent. I've also added tests; which apparently were quite useful in extracting bugs.
I've explicitly disallowed having multiple entries for the same source or the same destination. You can lose columns by renaming some column to an existing column name; it was easy to support and there may be legitimate uses.
Nightlies: https://github.com/nbauernfeind/deephaven-core/actions/runs/8085227568