Fixed a bug in managing context objects #5195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malhotrashivam
added
parquet
rcaudy
approved these changes
Feb 26, 2024
malhotrashivam
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug got introduced in how context objects are managed by ColumnChunkPageStore in #4972.
The code assumed that the inner context is a ChannelContextWrapper, which prevents us from intermixing other types of column locations with Parquet ones. For example, If we mixs Deephaven format with Parquet format, this crashes because the first location is Deephaven format with a non-null inner context. When it comes around to the next location (which is the parquet location) it dies because it just assumes that a non-null inner context means a Parquet one was created before.
This bug was found by @abaranec while trying to merge in 0.33.0 into Core+.