Added py.typed marker for deephaven #5196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jianfeng Mao <4297243+jmao-denver@users.noreply.github.com>
bierus
requested review from
chipkent,
jmao-denver and
rcaudy
as code owners
|
@jmao-denver I opened a new PR as you requested |
rcaudy
added
feature request
|
Continuation of #5189 that was accidentally closed. |
jmao-denver
approved these changes
Feb 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently forced to write our custom *.pyi stubs for mypy to use static type checking for our deephaven Python scripts. I'm adding py.typed marker to deephaven root to directly use the typing provided by the deephaven Team.
PEP:
https://peps.python.org/pep-0561/#packaging-type-information