-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve WindowCheck memory usage. #5197
Conversation
c1782f0
to
61a1702
Compare
61a1702
to
fd8791b
Compare
fd8791b
to
280d0bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly formatting and renaming comments.
engine/table/src/main/java/io/deephaven/engine/util/WindowCheck.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/util/WindowCheck.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/util/WindowCheck.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/util/WindowCheck.java
Outdated
Show resolved
Hide resolved
engine/table/src/test/java/io/deephaven/engine/util/TestWindowCheck.java
Outdated
Show resolved
Hide resolved
engine/table/src/test/java/io/deephaven/engine/util/TestWindowCheck.java
Outdated
Show resolved
Hide resolved
engine/table/src/test/java/io/deephaven/engine/util/TestWindowCheck.java
Outdated
Show resolved
Hide resolved
engine/table/src/test/java/io/deephaven/engine/util/TestWindowCheck.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
engine/table/src/main/java/io/deephaven/engine/util/WindowCheck.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/util/WindowCheck.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/util/WindowCheck.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Ryan Caudy <rcaudy@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How long do the WindowCheck tests take now vs before?
final long priorEntryLastNanos = | ||
inWindowColumnSource.timeStampSource.getLong(priorEntry.lastRowKey); | ||
if (priorEntryLastNanos <= currentTimestamp) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can skip this getLong
in the singleton case.
engine/table/src/main/java/io/deephaven/engine/util/WindowCheck.java
Outdated
Show resolved
Hide resolved
…k.java Co-authored-by: Ryan Caudy <rcaudy@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
No description provided.