Improve WindowCheck memory usage. #5197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpwright
added
NoDocumentationNeeded
NoReleaseNotesNeeded
cpwright
force-pushed
the
nightly/cpw_windowcheck
branch
from
c1782f0
to
61a1702
Compare
cpwright
force-pushed
the
nightly/cpw_windowcheck
branch
from
61a1702
to
fd8791b
Compare
cpwright
force-pushed
the
nightly/cpw_windowcheck
branch
from
fd8791b
to
280d0bd
Compare
rcaudy
reviewed
Feb 27, 2024
engine/table/src/main/java/io/deephaven/engine/util/WindowCheck.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/util/WindowCheck.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/util/WindowCheck.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/util/WindowCheck.java
Outdated
Show resolved
Hide resolved
engine/table/src/test/java/io/deephaven/engine/util/TestWindowCheck.java
Outdated
Show resolved
Hide resolved
engine/table/src/test/java/io/deephaven/engine/util/TestWindowCheck.java
Outdated
Show resolved
Hide resolved
engine/table/src/test/java/io/deephaven/engine/util/TestWindowCheck.java
Outdated
Show resolved
Hide resolved
engine/table/src/test/java/io/deephaven/engine/util/TestWindowCheck.java
Outdated
Show resolved
Hide resolved
rcaudy
reviewed
Feb 27, 2024
engine/table/src/main/java/io/deephaven/engine/util/WindowCheck.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/util/WindowCheck.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/util/WindowCheck.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Ryan Caudy <rcaudy@gmail.com>
rcaudy
reviewed
Feb 28, 2024
Comment on lines
429
to
431
| final long priorEntryLastNanos = | ||
| inWindowColumnSource.timeStampSource.getLong(priorEntry.lastRowKey); | ||
| if (priorEntryLastNanos <= currentTimestamp) { |
There was a problem hiding this comment.
You can skip this getLong in the singleton case.
engine/table/src/main/java/io/deephaven/engine/util/WindowCheck.java
Outdated
Show resolved
Hide resolved
…k.java Co-authored-by: Ryan Caudy <rcaudy@gmail.com>
rcaudy
approved these changes
Feb 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.