build: Add provenence flag when publishing jsapi-types #5204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mofojed
commented
Feb 28, 2024
mofojed
commented
- .npmrc file is not getting used with how we publish (building the tarball first and then publishing from a different directory)
- Adding the --provenance flag should generate the provenance statements automatically: https://docs.npmjs.com/generating-provenance-statements#publishing-packages-with-provenance-via-github-actions
- This should work even publishing from the tarball, as the provenance info is generated after the tarball is created: https://github.com/npm/provenance?tab=readme-ov-file#demo-generating-signed-slsa-provenance
- .npmrc file is not getting used with how we publish (building the tarball first and then publishing from a different directory) - Adding the --provenance flag should generate the provenance statements automatically: https://docs.npmjs.com/generating-provenance-statements#publishing-packages-with-provenance-via-github-actions - This _should_ work even publishing from the tarball, as the provenance info is generated after the tarball is created: https://github.com/npm/provenance?tab=readme-ov-file#demo-generating-signed-slsa-provenance
mofojed
added
NoDocumentationNeeded
NoReleaseNotesNeeded
mofojed
requested review from
devinrsmith,
jcferretti,
JamesXNelson and
rcaudy
as code owners
devinrsmith
approved these changes
Mar 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.