Reduce memory footprint in UpdateBy rolling time operatations
#5215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbooker42
added
NoDocumentationNeeded
NoReleaseNotesNeeded
lbooker42
commented
Mar 4, 2024
| finalizeWindowBucket(context); | ||
| return; | ||
| } | ||
| try (final ChunkSource.GetContext tsContext = ctx.timestampColumnSource.makeGetContext(ctx.workingChunkSize)) { |
There was a problem hiding this comment.
This is the important line. Try-with-resources here and pass the context to the calling functions instead of keeping as a member.
There was a problem hiding this comment.
Github is having a problem with matching the lines, even though they are unchanged. Sorry for the confusion. Assuming it is the indentation.
rcaudy
approved these changes
Mar 4, 2024
|
A "level up" would be to add |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A timestamp value context was being retained for every bucket after its use expired. Replaced with a
try-with-resourcesand modified the functions using it to accept the context as an input parameter.