Generalize Python InputTable class #5236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arman-ddl
added
python
NoDocumentationNeeded
input-tables
NoReleaseNotesNeeded
arman-ddl
added this to the 2023 tickets that need to be 'milestone-ed' and assigned milestone
jmao-denver
requested changes
Mar 11, 2024
|
Please also create some test cases for the new methods in `test_table_factory.py' |
Per jmao-denver Co-authored-by: Jianfeng Mao <4297243+jmao-denver@users.noreply.github.com>
…rman_python_input_tables # Conflicts: # py/server/deephaven/table_factory.py
jmao-denver
requested changes
Mar 11, 2024
Per jmao Co-authored-by: Jianfeng Mao <4297243+jmao-denver@users.noreply.github.com>
rcaudy
reviewed
Mar 12, 2024
chipkent
reviewed
Mar 12, 2024
Per Chip Co-authored-by: Chip Kent <5250374+chipkent@users.noreply.github.com>
…rman_python_input_tables
chipkent
approved these changes
Mar 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Python InputTable class is tied to the in-memory Core impls, but it can just accept a table that is supposed to have an input table attribute. This will be beneficial to e.g. Core+ where we can plug in our own implementation and users can use the same experience for both Core and Core+ input tables.