Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for empty data for add/delete/+async on InputTable #5242

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Check for empty data for add/delete/+async on InputTable #5242

merged 1 commit into from
Mar 12, 2024

Conversation

jmao-denver
Copy link
Contributor

Fixes #5240

@jmao-denver jmao-denver added bug Something isn't working input-tables labels Mar 12, 2024
@jmao-denver jmao-denver added this to the 1. March 2024 milestone Mar 12, 2024
@jmao-denver jmao-denver self-assigned this Mar 12, 2024
@jmao-denver jmao-denver changed the title Check for empty data for add/delete/+async Check for empty data for add/delete/+async on InputTable Mar 12, 2024
@rcaudy rcaudy merged commit 7a6edb5 into deephaven:main Mar 12, 2024
21 of 27 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2024
@jmao-denver jmao-denver deleted the 5240-input-table-ticking-deadlock branch March 18, 2024 20:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chipkent chipkent chipkent approved these changes

@rcaudy rcaudy rcaudy approved these changes

Assignees

@jmao-denver jmao-denver

Labels
bug Something isn't working input-tables NoDocumentationNeeded ReleaseNotesNeeded Release notes are needed
Projects
None yet
Milestone
1. March 2024
Development

Successfully merging this pull request may close these issues.

Adding a ticking table to an InputTable appears to be deadlocking under locks.
3 participants
@jmao-denver @chipkent @rcaudy