-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make time of day methods handle daylight savings time (DST) better #5245
Conversation
…avings time problems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some small comments
@ScriptApi | ||
@Deprecated | ||
public static int millisOfDay(@Nullable final Instant instant, @Nullable final ZoneId timeZone) { | ||
return millisOfDay(instant, timeZone, false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what the culture is here, but I'm feeling a little sad that we have to provide all these ${UNIT}OfDay
methods. Would it be ok just to provide nanosOfDay
and let our user call nanosTo${UNIT}
e.g. nanosToSeconds
or whatever?
Just an observation, I'm not deeply opinionated on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is part of an intentional decision made long ago to target concise syntax for command line users. The proposed change results in more verbose query strings.
Labels indicate documentation is required. Issues for documentation have been opened: Community: deephaven/deephaven-docs-community#172 |
Change time of day methods to handle daylight savings time better.
The old method signatures are deprecated and need to be removed in a version or two.
Resolves #5244