Make time of day methods handle daylight savings time (DST) better #5245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…avings time problems.
kosak
reviewed
Mar 14, 2024
| @ScriptApi | ||
| @Deprecated | ||
| public static int millisOfDay(@Nullable final Instant instant, @Nullable final ZoneId timeZone) { | ||
| return millisOfDay(instant, timeZone, false); |
There was a problem hiding this comment.
I don't know what the culture is here, but I'm feeling a little sad that we have to provide all these ${UNIT}OfDay methods. Would it be ok just to provide nanosOfDay and let our user call nanosTo${UNIT} e.g. nanosToSeconds or whatever?
Just an observation, I'm not deeply opinionated on this.
There was a problem hiding this comment.
This is part of an intentional decision made long ago to target concise syntax for command line users. The proposed change results in more verbose query strings.
kosak
approved these changes
Mar 19, 2024
|
Labels indicate documentation is required. Issues for documentation have been opened: Community: deephaven/deephaven-docs-community#172 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change time of day methods to handle daylight savings time better.
The old method signatures are deprecated and need to be removed in a version or two.
Resolves #5244