Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove the original doc-ci.yml action as it's output is now unused #5250

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

dsmmcken
Copy link
Contributor

Rename the newer docs-ci-v2 as just docs-ci.yml. The website now only uses output from the newer action. I made no changes other delete and rename.

Note: I've left that rsynced path as deephaven-core-v2/ on the server, as that's where all the symlinks point and I am being lazy and don't want to have to co-ordinate swapping that live.

Rename the newer docs-ci-v2 as just docs-ci.yml. The website now only uses output from the newer action. I made no changes other delete and rename.

Note: I've left that rsynced path as deephaven-core-v2/ on the server, as that's where all the symlinks point and I am being lazy and don't want to have to co-ordinate swapping that live.
Copy link
Contributor

@stanbrub stanbrub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Overwriting the original saves us from having to modify the PR check list.

@stanbrub stanbrub added the NoReleaseNotesNeeded No release notes are needed. label Mar 14, 2024
Copy link
Member

@devinrsmith devinrsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this was just a simple delete + move (as PR description says). Would be easier to review this pattern in the future if it were broken down into two separate commits in the PR.

@dsmmcken dsmmcken merged commit 07cf44c into deephaven:main Mar 18, 2024
15 of 18 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants