Check arg type against Py UDF signature at query compile time #5254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmao-denver
added
DocumentationNeeded
ReleaseNotesNeeded
jmao-denver
changed the title
| @@ -1968,6 +1968,39 @@ static boolean isWideningPrimitiveConversion(Class<?> original, Class<?> target) | |||
| return false; | |||
| } | |||
|
|
|||
| public static boolean isLosslessWideningPrimitiveConversion(Class<?> original, Class<?> target) { | |||
There was a problem hiding this comment.
This is interesting. Historically we've allowed widening from Long to Float. I see how this is lossy.
Is this used to disable vectorization? Or is it used to disable lossy widening?
There was a problem hiding this comment.
See 5.1.2 on https://docs.oracle.com/javase/specs/jls/se9/html/jls-5.html. The intention here is to ensure lossless conversion.
jmao-denver
force-pushed
the
5221-compile-time-arg-check
branch
from
0b49a64
to
ccc392f
Compare
chipkent
reviewed
Mar 20, 2024
engine/table/src/main/java/io/deephaven/engine/table/impl/lang/QueryLanguageParser.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/lang/QueryLanguageParser.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/lang/QueryLanguageParser.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/lang/QueryLanguageParser.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/lang/QueryLanguageParser.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/lang/QueryLanguageParser.java
Show resolved
Hide resolved
jmao-denver
force-pushed
the
5221-compile-time-arg-check
branch
from
1f9167e
to
b6d8cfc
Compare
chipkent
reviewed
Mar 22, 2024
engine/table/src/main/java/io/deephaven/engine/table/impl/lang/QueryLanguageParser.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/util/PyCallableWrapperJpyImpl.java
Show resolved
Hide resolved
| return false; | ||
| } | ||
|
|
||
| public static boolean isLosslessWideningPrimitiveConversion(Class<?> original, Class<?> target) { |
There was a problem hiding this comment.
A unit test for this would be a good addition.
There was a problem hiding this comment.
- This particular class is not being tested in the JUnit tests probably due to the fact that it needs a non-trivial amount of work to properly wire everything up to test it in Java.
- The Python unit tests indirectly test this method in a pretty comprehensive way. Maybe we can do a bit more from the Python side.
There was a problem hiding this comment.
- This is a static method that takes
Classparameters. It should be very easy to unit test in Java. - Unit tests like this should happen in Java when possible. That way things like coverage can be assessed.
- Additional Python tests should support the Java testing and not replace it.
- I suspect the lack of unit tests resulted from a lack of diligence at some point in the last 15 years. Now we are at a point where it looks like a lot of work to test everything. This is why I suggested testing a single static function.
engine/table/src/main/java/io/deephaven/engine/util/PyCallableWrapperJpyImpl.java
Show resolved
Hide resolved
chipkent
approved these changes
Mar 25, 2024
|
Labels indicate documentation is required. Issues for documentation have been opened: Community: deephaven/deephaven-docs-community#179 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5221