Implement DisplayWrapper#hashCode to fix SelectDistinct Behavior of Previewed Columns #5281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbauernfeind
added
bug
niloc132
approved these changes
Mar 22, 2024
|
Won't this have a problem with preview columns with array values? The server wouldn't match the client filter in that case. Perhaps we're not concerned with that case here, but worth calling out/commenting on. |
|
I thought Arrays used |
rcaudy
approved these changes
May 16, 2024
|
We should merge this. Then, we should consider "better" fixes:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a behavior that makes #5280 more sane, but doesn't fix the "underlying" issue which is that we probably shouldn't support UI filters (quick or advanced) on previewed columns.