-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for specifying extra class paths to embedded server. #5282
Allow for specifying extra class paths to embedded server. #5282
Conversation
…up of the embedded server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me... any reason we should accept any of the other parameters?
jvm_properties = None,
java_home = None,
extra_classpath = [],
propfile: str = None,
config = None
I am more than happy to add wiring for all of these if we want, won't take me long so let me know! |
I might prefer to expose less for now to give ourselves the flexibility to change in the future if we need to. For example, I think setting an explicit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This wires in the
extra_classpath
argument fromstart_jvm
to the constructor for theServer
instance. This will allow for users to easily write python unit tests that can interact with custom Java implementations as well.