Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python ticking client: if no Barrage metadata, pass NULL to C++ handler #5283

Merged
merged 1 commit into from
Mar 23, 2024
Merged

Python ticking client: if no Barrage metadata, pass NULL to C++ handler #5283

merged 1 commit into from
Mar 23, 2024

Conversation

kosak
Copy link
Contributor

@kosak kosak commented Mar 22, 2024

This fixes a bug where previously, if raw_metadata was None, we would get an error as Python tried to access raw_metadata[0]

@kosak kosak self-assigned this Mar 22, 2024
@kosak kosak added NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. labels Mar 22, 2024
@kosak kosak enabled auto-merge (squash) March 22, 2024 21:30
jmao-denver
jmao-denver approved these changes Mar 23, 2024
View reviewed changes
Copy link
Contributor

@jmao-denver jmao-denver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kosak kosak merged commit 4089d2b into deephaven:main Mar 23, 2024
17 of 19 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2024
@kosak kosak deleted the kosak_barrage-metadata branch March 23, 2024 00:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jmao-denver jmao-denver jmao-denver approved these changes

@chipkent chipkent Awaiting requested review from chipkent chipkent is a code owner

@rcaudy rcaudy Awaiting requested review from rcaudy rcaudy is a code owner

Assignees

@kosak kosak

Labels
NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kosak @jmao-denver