Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++ client: make sure that the select test covers all types #5284

Merged
merged 1 commit into from
Mar 22, 2024
Merged

C++ client: make sure that the select test covers all types #5284

merged 1 commit into from
Mar 22, 2024

Conversation

kosak
Copy link
Contributor

@kosak kosak commented Mar 22, 2024

The "Support all types" unit test was previously not covering the DateTime type.

@kosak kosak self-assigned this Mar 22, 2024
@kosak kosak requested a review from jcferretti March 22, 2024 21:33
@kosak kosak added NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. labels Mar 22, 2024
@kosak kosak merged commit eb6ba03 into deephaven:main Mar 22, 2024
17 of 19 checks passed
@kosak kosak deleted the kosak_select-test-all-types branch March 22, 2024 22:25
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jcferretti jcferretti jcferretti approved these changes

Assignees

@kosak kosak

Labels
NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kosak @jcferretti