C++ client: process Barrage shifts properly #5285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosak
added
NoDocumentationNeeded
NoReleaseNotesNeeded
jcferretti
approved these changes
Mar 22, 2024
| immer::for_each_chunk(src_beginp, src_endp, copy_nulls_inner); | ||
| }; | ||
| rows.ForEachInterval(copy_nulls_outer); | ||
| } else { |
There was a problem hiding this comment.
Since the function is about to return right after the else anyway, can you consider short-circuiting this else by returning in the body of the if above, and then removing the else?
Looking at the actual file is going to be easier than trying to follow the logic in the diff, but in either case, I find that is easier for me to read code when you allow me to drop stacks of context earlier.
There was a problem hiding this comment.
We discussed on slack, it is an if constexpr so my comment doesn't apply/work.
| sep = ", "; | ||
| } | ||
| s << '[' << start << ',' << end << ')'; |
There was a problem hiding this comment.
That is an opening brace and a close parens... is that intentional?
There was a problem hiding this comment.
I guess it is because is an open interval, nevermind...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes three things.
SpaceMapper::ApplyShift(space_mapper.cc) was simply wrong. When Barrage communicates a shift in the range [begin, end), the old code would remove [begin, end) from the rowset and then add the whole range [begin+offset, end+offset) to the rowset. The correct behavior is to only add the subset of the range that already existed in the rowset.