Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ Client: fix FillChunk and missing types for ticking callbacks #5286

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

kosak
Copy link
Contributor

@kosak kosak commented Mar 22, 2024

This PR has three fixes:

  1. Add missing ++'s in arrow_column_source.h which were preventing data from being properly copied in during chunk fills.
  2. Adds support for some missing ticking types
  3. Add a unit test that iteratively populates a ticking table with all the Deephaven types, and confirms that all the data arrives. This is similar in flavor to the select test for static tables. This is a unit test that confirms that the bug referenced in item 1 is fixed.
  4. Adds range checking for Schema::GetColumn(index)

@kosak kosak self-assigned this Mar 22, 2024
@kosak kosak added NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. labels Mar 22, 2024
@kosak kosak requested a review from jcferretti March 22, 2024 21:57
@kosak kosak merged commit 1b728f0 into deephaven:main Mar 22, 2024
15 checks passed
@kosak kosak deleted the kosak_ticking-fillchunk branch March 22, 2024 23:04
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants