Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to gradle 8.7 #5287

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

devinrsmith
Copy link
Member

@devinrsmith devinrsmith commented Mar 22, 2024

See https://docs.gradle.org/8.7/release-notes.html.

This is a required, but not complete, prerequisite for testing with Java 22. We'll need to bump groovy versions to pick up full testable support.

@devinrsmith devinrsmith added this to the 1. March 2024 milestone Mar 22, 2024
@devinrsmith devinrsmith self-assigned this Mar 22, 2024
@devinrsmith devinrsmith marked this pull request as ready for review March 24, 2024 17:41
Copy link
Member

@niloc132 niloc132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, big caveat: it is not safe to run either gradle or DH tests/runtime with Java 22 at this time, Groovy will need to be updated first. Groovy is/was blocked on an asm.jar update, then we'll need to update our groovy version as well. Please remove or qualify the note in the description.

@devinrsmith devinrsmith merged commit db4c2fa into deephaven:main Mar 25, 2024
23 checks passed
@devinrsmith devinrsmith deleted the nightly/gradle-8.7 branch March 25, 2024 19:14
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants