Improve DynamicWhereFilter performance #5293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lots of changes but tests passing.
…. Add abstract length() method.
Rwc index lookup via tuples
Hopefully better code.
… favor of sourceKeySource.
…r now, since we were relying on a specific implementation that's not dissimilar from ours.
rcaudy
commented
Mar 26, 2024
| Require.geq(partialKeySize, "partialKeySize", 2, "2"); | ||
|
|
||
| final Object[] keysInDataIndexOrder = new Object[partialKeySize]; | ||
| // TODO: decide if this is ridiculous or clever. Trying to avoid looping inside the lambda if possible and |
There was a problem hiding this comment.
From a sheer "look at how much code there is" I kind of hate it. If benchmarks show it to be better, we can keep it, I guess.
There was a problem hiding this comment.
Not offended, it's very ugly and probably pointless to attempt to outguess the JIT.
engine/table/src/main/java/io/deephaven/engine/table/impl/select/DynamicWhereFilter.java
Outdated
Show resolved
Hide resolved
lbooker42
reviewed
Mar 26, 2024
| Require.geq(partialKeySize, "partialKeySize", 2, "2"); | ||
|
|
||
| final Object[] keysInDataIndexOrder = new Object[partialKeySize]; | ||
| // TODO: decide if this is ridiculous or clever. Trying to avoid looping inside the lambda if possible and |
There was a problem hiding this comment.
Not offended, it's very ugly and probably pointless to attempt to outguess the JIT.
...src/main/java/io/deephaven/engine/table/impl/select/setinclusion/ByteSetInclusionKernel.java
Show resolved
Hide resolved
rcaudy
added
query engine
core
Rwc index lookup via tuples
lbooker42
approved these changes
Mar 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5268