Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RspRowSequence and SortedRangesRowSequence should invalidate their RowSequenceAsChunkImpl on reset instead of closing it #5302

Merged
merged 2 commits into from
Mar 28, 2024
Merged

RspRowSequence and SortedRangesRowSequence should invalidate their RowSequenceAsChunkImpl on reset instead of closing it #5302

merged 2 commits into from
Mar 28, 2024

Conversation

rcaudy
Copy link
Member

@rcaudy rcaudy commented Mar 28, 2024

No description provided.

@rcaudy
RspRowSequence and SortedRangesRowSequence should invalidate their Ro…
6d19427 
…wSequenceAsChunkImpl on reset instead of closing it
@rcaudy rcaudy added query engine core Core development tasks NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. labels Mar 28, 2024
@rcaudy rcaudy added this to the 1. March 2024 milestone Mar 28, 2024
@rcaudy rcaudy requested a review from jcferretti March 28, 2024 03:00
@rcaudy rcaudy self-assigned this Mar 28, 2024
@rcaudy rcaudy marked this pull request as ready for review March 28, 2024 03:39
jcferretti
jcferretti previously approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@jcferretti jcferretti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it parrot.

@rcaudy rcaudy merged commit 40faee9 into deephaven:main Mar 28, 2024
15 checks passed
@rcaudy rcaudy deleted the rwc-invalidate-not-close branch March 28, 2024 05:36
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jcferretti jcferretti jcferretti approved these changes

Assignees

@rcaudy rcaudy

Labels
core Core development tasks NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. query engine
Projects
None yet
Milestone
1. March 2024
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rcaudy @jcferretti