Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap the new data indexing feature in Python #5306

Merged
merged 8 commits into from
Apr 3, 2024
Merged

Wrap the new data indexing feature in Python #5306

merged 8 commits into from
Apr 3, 2024

Conversation

jmao-denver
Copy link
Contributor

Fixes #5263

@jmao-denver jmao-denver added this to the 1. March 2024 milestone Mar 28, 2024
@jmao-denver jmao-denver self-assigned this Mar 28, 2024
lbooker42
lbooker42 reviewed Mar 28, 2024
View reviewed changes
Copy link
Contributor

@lbooker42 lbooker42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problems, questions about testing and naming.

py/server/tests/test_data_index.py Show resolved Hide resolved
py/server/deephaven/experimental/data_index.py Outdated Show resolved Hide resolved
rcaudy
rcaudy reviewed Mar 29, 2024
View reviewed changes
py/server/deephaven/experimental/data_index.py Show resolved Hide resolved
py/server/deephaven/experimental/data_index.py Outdated Show resolved Hide resolved
py/server/deephaven/experimental/data_index.py Outdated Show resolved Hide resolved
py/server/deephaven/experimental/data_index.py Outdated Show resolved Hide resolved
py/server/deephaven/experimental/data_index.py Outdated Show resolved Hide resolved
@stanbrub stanbrub mentioned this pull request Mar 29, 2024
Closed
chipkent
chipkent reviewed Apr 1, 2024
View reviewed changes
py/server/deephaven/experimental/data_index.py Outdated Show resolved Hide resolved
py/server/deephaven/experimental/data_index.py Show resolved Hide resolved
py/server/deephaven/experimental/data_index.py Outdated Show resolved Hide resolved
py/server/deephaven/experimental/data_index.py Outdated Show resolved Hide resolved
py/server/deephaven/experimental/data_index.py Show resolved Hide resolved
py/server/deephaven/experimental/data_index.py Outdated Show resolved Hide resolved
py/server/deephaven/experimental/data_index.py Outdated Show resolved Hide resolved
py/server/deephaven/experimental/data_index.py Outdated Show resolved Hide resolved
py/server/tests/test_data_index.py Show resolved Hide resolved
py/server/tests/test_data_index.py Outdated Show resolved Hide resolved
jmao-denver and others added 2 commits April 1, 2024 14:30
@jmao-denver @chipkent
Apply suggestions from code review
5302578 
Co-authored-by: Chip Kent <5250374+chipkent@users.noreply.github.com>
@jmao-denver
Respond to reivew comments
3194b19
chipkent
chipkent reviewed Apr 2, 2024
View reviewed changes
py/server/tests/test_data_index.py Outdated Show resolved Hide resolved
py/server/tests/test_data_index.py Outdated Show resolved Hide resolved
rcaudy
rcaudy reviewed Apr 2, 2024
View reviewed changes
Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

jmao-denver and others added 2 commits April 3, 2024 13:27
@jmao-denver @chipkent
Apply suggestions from code review
88b5986 
Co-authored-by: Chip Kent <5250374+chipkent@users.noreply.github.com>
@jmao-denver
Renaming create_data_index to data_index
7b13aaa
@jmao-denver jmao-denver merged commit 14f8ca3 into deephaven:main Apr 3, 2024
15 checks passed
@jmao-denver jmao-denver deleted the 5263-wrap-data-indexer branch April 3, 2024 20:48
@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2024
@deephaven-internal
Copy link
Contributor

Labels indicate documentation is required. Issues for documentation have been opened:

Community: deephaven/deephaven-docs-community#182

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chipkent chipkent chipkent approved these changes

@lbooker42 lbooker42 Awaiting requested review from lbooker42

@rcaudy rcaudy Awaiting requested review from rcaudy rcaudy is a code owner

Assignees

@jmao-denver jmao-denver

Labels
DocumentationNeeded python-server-side ReleaseNotesNeeded Release notes are needed
Projects
None yet
Milestone
1. March 2024
Development

Successfully merging this pull request may close these issues.

Wrap the new data indexing feature in Python (probably in the experimental sub-package)
5 participants
@jmao-denver @deephaven-internal @lbooker42 @chipkent @rcaudy