Introduce TableUpdateImpl copy that takes an MCS #5319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows allows the majority of copy callsites to be more efficient when they know they are going to overwrite the resulting modifiedColumnSet anyways (which is the majority of copy calls)
devinrsmith
added
query engine
NoDocumentationNeeded
NoReleaseNotesNeeded
rcaudy
reviewed
Apr 3, 2024
engine/table/src/main/java/io/deephaven/engine/table/impl/TableUpdateValidator.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/util/TickSuppressor.java
Outdated
Show resolved
Hide resolved
Yep, BarrageMessageProducer is the only caller now :) Kicking off nightlies. |
rcaudy
approved these changes
Apr 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows allows the majority of copy callsites to be more efficient when they know they are going to overwrite the resulting modifiedColumnSet anyways.