-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Widen returned types for UpdateBy
floating point operations.
#5371
Conversation
engine/table/src/test/java/io/deephaven/engine/table/impl/updateby/TestCumSum.java
Show resolved
Hide resolved
@@ -81,7 +84,7 @@ public void pop(int count) { | |||
@Override | |||
public void writeToOutputChunk(int outIdx) { | |||
if (aggSum.size() == nullCount) { | |||
outputValues.set(outIdx, NULL_FLOAT); | |||
outputValues.set(outIdx, NULL_DOUBLE); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't match sum(DoubleVector)
or sum(FloatVector)
in Numeric
. Which is right, @chipkent ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you are looking at something old. The latest Numeric.sum
does return NULL_DOUBLE
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may have commented on a differnt case. Looking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If they are all null, it would make sense to return NULL_DOUBLE
. I think Numeric.ftl
needs to be changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want me to change it in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. In that case, I think we can merge Larry's PR, and have follow-up work for the numerics.
engine/table/src/test/java/io/deephaven/engine/table/impl/updateby/TestCumSum.java
Show resolved
Hide resolved
Labels indicate documentation is required. Issues for documentation have been opened: Community: deephaven/deephaven-docs-community#208 |
The following operations returned
Float
types when providedFloat
input and are changed by this PR to returnDouble
:Companion to #5368 and will close #4023
Also close #5459 (test failures issue)