Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support publishing/sharing anonymous tables between different sessions in Python client/server APIs #5374

Merged
merged 25 commits into from
Apr 25, 2024
Merged

Support publishing/sharing anonymous tables between different sessions in Python client/server APIs #5374

merged 25 commits into from
Apr 25, 2024

Conversation

jmao-denver
Copy link
Contributor

@jmao-denver jmao-denver commented Apr 17, 2024 •
edited
Loading

Fixes #5372
Fixes #5229

@jmao-denver jmao-denver added this to the 1. March 2024 milestone Apr 17, 2024
@jmao-denver jmao-denver self-assigned this Apr 17, 2024
@jmao-denver jmao-denver changed the title WIP - may need to add a Ticket class Support publishing anonymous tables for sharing with other sessions Apr 17, 2024
@jmao-denver jmao-denver marked this pull request as ready for review April 17, 2024 14:51
rcaudy
rcaudy reviewed Apr 17, 2024
View reviewed changes
py/client/pydeephaven/session.py Show resolved Hide resolved
py/client/pydeephaven/session.py Outdated Show resolved Hide resolved
rcaudy
rcaudy reviewed Apr 17, 2024
View reviewed changes
Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@devinrsmith devinrsmith mentioned this pull request Apr 18, 2024
Merged
devinrsmith
devinrsmith reviewed Apr 19, 2024
View reviewed changes
py/client/pydeephaven/_session_service.py Outdated Show resolved Hide resolved
py/client/pydeephaven/session.py Show resolved Hide resolved
py/client/pydeephaven/session.py Outdated Show resolved Hide resolved
py/server/deephaven/remote.py Outdated Show resolved Hide resolved
py/server/deephaven/remote.py Outdated Show resolved Hide resolved
py/server/deephaven/remote.py Outdated Show resolved Hide resolved
py/server/deephaven/remote.py Outdated Show resolved Hide resolved
py/server/tests/test_remote.py Outdated Show resolved Hide resolved
@jmao-denver jmao-denver changed the title Support publishing anonymous tables for sharing with other sessions Support publishing/sharing anonymous tables between different sessions in Python client/server APIs Apr 20, 2024
devinrsmith
devinrsmith reviewed Apr 22, 2024
View reviewed changes
py/server/deephaven/barrage.py Outdated Show resolved Hide resolved
py/server/deephaven/barrage.py Outdated Show resolved Hide resolved
chipkent
chipkent reviewed Apr 22, 2024
View reviewed changes
py/client/pydeephaven/_session_service.py Outdated Show resolved Hide resolved
py/client/pydeephaven/session.py Show resolved Hide resolved
py/client/pydeephaven/session.py Outdated Show resolved Hide resolved
py/client/pydeephaven/session.py Outdated Show resolved Hide resolved
py/client/pydeephaven/session.py Outdated Show resolved Hide resolved
py/server/tests/test_barrage.py Outdated Show resolved Hide resolved
py/server/tests/test_barrage.py Outdated Show resolved Hide resolved
py/server/tests/test_barrage.py Outdated Show resolved Hide resolved
py/server/tests/test_barrage.py Outdated Show resolved Hide resolved
py/server/tests/test_barrage.py Show resolved Hide resolved
niloc132
niloc132 reviewed Apr 22, 2024
View reviewed changes
Integrations/build.gradle Outdated Show resolved Hide resolved
chipkent
chipkent reviewed Apr 25, 2024
View reviewed changes
py/server/deephaven/barrage.py Outdated Show resolved Hide resolved
py/server/deephaven/barrage.py Outdated Show resolved Hide resolved
py/server/deephaven/barrage.py Show resolved Hide resolved
py/server/tests/test_barrage.py Outdated Show resolved Hide resolved
chipkent
chipkent previously approved these changes Apr 25, 2024
View reviewed changes
chipkent
chipkent previously approved these changes Apr 25, 2024
View reviewed changes
rcaudy
rcaudy previously approved these changes Apr 25, 2024
View reviewed changes
devinrsmith
devinrsmith requested changes Apr 25, 2024
View reviewed changes
py/server/deephaven/barrage.py Outdated Show resolved Hide resolved
py/server/deephaven/barrage.py Outdated Show resolved Hide resolved
py/server/deephaven/barrage.py Outdated Show resolved Hide resolved
@jmao-denver jmao-denver dismissed stale reviews from rcaudy and chipkent via e8f4449 April 25, 2024 22:29
@jmao-denver jmao-denver enabled auto-merge (squash) April 25, 2024 22:56
@jmao-denver jmao-denver merged commit aeeedd8 into deephaven:main Apr 25, 2024
15 checks passed
@jmao-denver jmao-denver deleted the 5372-share-export-pyclient branch April 25, 2024 23:06
@deephaven-internal
Copy link
Contributor

Labels indicate documentation is required. Issues for documentation have been opened:

Community: deephaven/deephaven-docs-community#204

@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rcaudy rcaudy rcaudy approved these changes

@devinrsmith devinrsmith devinrsmith approved these changes

@nbauernfeind nbauernfeind Awaiting requested review from nbauernfeind

@niloc132 niloc132 Awaiting requested review from niloc132

@chipkent chipkent Awaiting requested review from chipkent chipkent is a code owner

Assignees

@jmao-denver jmao-denver

@devinrsmith devinrsmith

Labels
DocumentationNeeded python-client ReleaseNotesNeeded Release notes are needed
Projects
None yet
Milestone
1. March 2024
Development

Successfully merging this pull request may close these issues.

Python Client: Add Shared ID Support Support for creating full barrage tables from pydeephaven tables
6 participants
@jmao-denver @deephaven-internal @niloc132 @chipkent @rcaudy @devinrsmith