Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++ Client: Make it work on Windows #5399

Merged
merged 5 commits into from
Apr 23, 2024
Merged

C++ Client: Make it work on Windows #5399

merged 5 commits into from
Apr 23, 2024

Conversation

kosak
Copy link
Contributor

@kosak kosak commented Apr 23, 2024 •
edited
Loading

Broadly this involves

  1. Some changes to CMake files
  2. config files for 'vcpkg', the Windows package manager
  3. Build instructions in README.md

@kosak kosak added NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. labels Apr 23, 2024
@kosak kosak added this to the 2. April 2024 milestone Apr 23, 2024
@kosak kosak requested a review from jcferretti April 23, 2024 19:44
@kosak kosak self-assigned this Apr 23, 2024
jcferretti
jcferretti previously approved these changes Apr 23, 2024
View reviewed changes
@kosak kosak merged commit d89558b into deephaven:main Apr 23, 2024
15 checks passed
@kosak kosak deleted the kosak_winbuild branch April 23, 2024 23:39
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jcferretti jcferretti jcferretti approved these changes

Assignees

@kosak kosak

Labels
NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed.
Projects
None yet
Milestone
2. April 2024
Development

Successfully merging this pull request may close these issues.
2 participants
@kosak @jcferretti